On Tue, Apr 16, 2019 at 05:48:07PM +0100, Jon Hunter wrote:
> Commit 5f84bb1a4099 ("soc/tegra: pmc: Add sysfs entries for reset info")
> added sysfs entries for Tegra reset source and level. However, these
> sysfs are not removed on error and so if the registering of PMC device
> is probe deferred, then the next time we attempt to probe the PMC device
> warnings such as the following will be displayed on boot ...
>
> sysfs: cannot create duplicate filename '/devices/platform/7000e400.pmc/reset_reason'
>
> Fix this by calling device_remove_file() for each sysfs entry added on
> failure. Note that we call device_remove_file() unconditionally without
> checking if the sysfs entry was created in the first place, but this
> should be OK because kernfs_remove_by_name_ns() will fail silently.
>
> Fixes: 5f84bb1a4099 ("soc/tegra: pmc: Add sysfs entries for reset info")
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>
> soc/tegra: pmc:
> ---
> Changes since V1:
> - Reverted changes to tegra_pmc_reset_sysfs_init()
> - Added unconditional calls to device_remove_file() in error path
>
> drivers/soc/tegra/pmc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied to for-5.2/soc, with that extra line removed, thanks.
Thierry
Attachment:
signature.asc
Description: PGP signature
