Re: [PATCH] memory: tegra: Fix a typos for "fdcdwr2" mc client.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



08.03.2019 14:21, Kejia Hu пишет:
> From: Edward Cragg <drq.11235@xxxxxxxxx>
> 
> Fix typo for fdcwr2 to fdcdwr2 to match the TRM.
> 
> Signed-off-by: Edward Cragg <drq.11235@xxxxxxxxx>
> Signed-off-by: Kejia Hu <kejia.hu@xxxxxxxxxxxxxxx>
> ---
>  drivers/memory/tegra/tegra114.c | 2 +-
>  drivers/memory/tegra/tegra30.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra114.c b/drivers/memory/tegra/tegra114.c
> index 6560a5101322..a16c70c558cb 100644
> --- a/drivers/memory/tegra/tegra114.c
> +++ b/drivers/memory/tegra/tegra114.c
> @@ -572,7 +572,7 @@ static const struct tegra_mc_client tegra114_mc_clients[] = {
>  		},
>  	}, {
>  		.id = 0x34,
> -		.name = "fdcwr2",
> +		.name = "fdcdwr2",
>  		.swgroup = TEGRA_SWGROUP_NV,
>  		.smmu = {
>  			.reg = 0x22c,
> diff --git a/drivers/memory/tegra/tegra30.c b/drivers/memory/tegra/tegra30.c
> index bee5314ed404..bd0e0d0b473b 100644
> --- a/drivers/memory/tegra/tegra30.c
> +++ b/drivers/memory/tegra/tegra30.c
> @@ -726,7 +726,7 @@ static const struct tegra_mc_client tegra30_mc_clients[] = {
>  		},
>  	}, {
>  		.id = 0x34,
> -		.name = "fdcwr2",
> +		.name = "fdcdwr2",
>  		.swgroup = TEGRA_SWGROUP_NV2,
>  		.smmu = {
>  			.reg = 0x22c,
> 

This is nearly ideal now! Please don't put a "dot" in the end of commit's name and if somebody gives a reviewed-by or acked-by, then you usually should add those tags to a new version of the patch if the tags are still actual. There is no need for a new version, Thierry could fix up the minor nits while applying the patch and I'll repeat my r-b here:

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux