Re: [PATCH] mc: tegra30/114: patch up a typo for "fdcdwr2" memory controller client.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



05.03.2019 16:03, Kejia Hu пишет:
> From: Edward Cragg <drq.11235@xxxxxxxxx>
> 
> Signed-off-by: Edward Cragg <drq.11235@xxxxxxxxx>
> Signed-off-by: Kejia Hu <kejia.hu@xxxxxxxxxxxxxxx>
> ---
>  drivers/memory/tegra/tegra114.c | 2 +-
>  drivers/memory/tegra/tegra30.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra114.c b/drivers/memory/tegra/tegra114.c
> index 6560a5101322..a16c70c558cb 100644
> --- a/drivers/memory/tegra/tegra114.c
> +++ b/drivers/memory/tegra/tegra114.c
> @@ -572,7 +572,7 @@ static const struct tegra_mc_client tegra114_mc_clients[] = {
>  		},
>  	}, {
>  		.id = 0x34,
> -		.name = "fdcwr2",
> +		.name = "fdcdwr2",
>  		.swgroup = TEGRA_SWGROUP_NV,
>  		.smmu = {
>  			.reg = 0x22c,
> diff --git a/drivers/memory/tegra/tegra30.c b/drivers/memory/tegra/tegra30.c
> index bee5314ed404..bd0e0d0b473b 100644
> --- a/drivers/memory/tegra/tegra30.c
> +++ b/drivers/memory/tegra/tegra30.c
> @@ -726,7 +726,7 @@ static const struct tegra_mc_client tegra30_mc_clients[] = {
>  		},
>  	}, {
>  		.id = 0x34,
> -		.name = "fdcwr2",
> +		.name = "fdcdwr2",
>  		.swgroup = TEGRA_SWGROUP_NV2,
>  		.smmu = {
>  			.reg = 0x22c,
> 


Hello Kejia,

Please add a commit message to the patch because it is mandatory for all patches. Secondly, please use the common prefix for the patch which is "memory: tegra: ", usually it is more preferable to have everything consistent.

Otherwise this looks good to me and the changed names are matching to the TRM definitions.

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux