On 28/02/2019 12:31, Peter Zijlstra wrote: > > Clearly, because reading comprehension isn't your strong point: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? Sorry we have a few people helping out cleaning up our kernel branches and we need to do a better job here indeed! > On Thu, Feb 28, 2019 at 12:14:09PM +0000, Sachin Nikam wrote: > >> This isn't a security fix. >> However, I see this is kind of code cleanup. > > As I've explained previously, it makes conceptual sense to have it in > the code, and any halfway sane compiler will observe the same double > store and eliminate it in its DCE pass. OK. Thanks for the feedback. We can agree to drop this and we will try to do a better job reviewing this type of thing before hand in future. Cheers Jon -- nvpublic
