Re: [PATCH] i2c: tegra: Only display error messages if DMA setup fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 21, 2019 at 03:00:38PM +0000, Jon Hunter wrote:
> From: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> 
> Commit 86c92b9965ff ("i2c: tegra: Add DMA support") added DMA support
> to the Tegra I2C driver for Tegra devices that support the APB DMA
> controller. One side-effect of this change is that even for Tegra
> devices that do not have an APB DMA controller and hence, cannot
> support DMA tranfers for I2C transactions, the following error messages
> are still displayed ...
> 
>  ERR KERN tegra-i2c 31c0000.i2c: cannot use DMA: -19
>  ERR KERN tegra-i2c 31c0000.i2c: falling back to PIO
> 
> There is no point displaying the above messages for devices that do not
> have an APB DMA controller and so fix this by returning from the
> tegra_i2c_init_dma() function if 'has_apb_dma' is not true.
> 
> Furthermore, if CONFIG_TEGRA20_APB_DMA is not set, then rather than
> printing an error message, print an debug message as for whatever reason
> this could be intentional.
> 
> Fixes: 86c92b9965ff ("i2c: tegra: Add DMA support")
> 
> Signed-off-by: Jonathan Hunter <jonathanh@xxxxxxxxxx>

Applied to for-next, thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux