Re: [PATCH] drm/tegra: vic: Do not clear driver data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



23.01.2019 16:42, Thierry Reding пишет:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> Upon driver failure, the driver core will take care of clearing the
> driver data, so there's no need to do so explicitly in the driver.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/tegra/vic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 9cb10d1e923a..d20fcbf6196d 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev)
>  	err = host1x_client_register(&vic->client.base);
>  	if (err < 0) {
>  		dev_err(dev, "failed to register host1x client: %d\n", err);
> -		platform_set_drvdata(pdev, NULL);
>  		goto exit_falcon;
>  	}
>  
> 

Looks good,

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux