On Mon, Jan 21, 2019 at 11:43:33AM +0100, Thierry Reding wrote: > On Tue, Jan 15, 2019 at 11:03:50AM -0800, Sowjanya Komatineni wrote: > > Add supports-cqe optional property for Tegra SDMMC. > > > > Tegra186 and Tegra194 supports HW Command queue only > > on SDMMC4 controller. This property is used to identify > > command queue support controller in the tegra sdhci driver. > > > > Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt > > index 32b4b4e41923..fb14c2c8d7ee 100644 > > --- a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt > > +++ b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt > > @@ -72,6 +72,10 @@ Optional properties for Tegra210 and Tegra186: > > - nvidia,default-trim : Specify the default outbound clock trimmer > > value. > > - nvidia,dqs-trim : Specify DQS trim value for HS400 timing > > +- supports-cqe : The presence of this property indicates that the > > + corresponding controller supports HW command queue feature. > > + Tegra186 and Tegra194 has 4 SDMMC Controllers and only SDMMC4 > > + controller supports HW Command Queue with eMMC device. > > Hi Rob, > > are you okay with the property name for this. I'm wondering if it should > have a vendor prefix or not, but I suspect that something like this may > be needed for other vendors as well, so not having a vendor prefix could > be warranted in this case. Seems likely. Please document with common MMC properties in that case. Rob
