Tony, On 16/01/19 9:17 PM, Tony Lindgren wrote: > * Thierry Reding <thierry.reding@xxxxxxxxx> [190116 13:28]: >> On Tue, Jan 15, 2019 at 05:28:36PM +0100, Thomas Petazzoni wrote: >>> The SDHCI core is know properly checking for the state of a WP GPIO, >> >> "know" -> "now" >> >>> so there is no longer any need for the sdhci-omap code to implement >>> ->get_ro() using mmc_gpio_get_ro(). >>> >>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> >>> --- >>> Note: this patch has only been compiled tested, as I don't have the >>> hardware to test it. >>> --- >>> drivers/mmc/host/sdhci-omap.c | 1 - >>> 1 file changed, 1 deletion(-) >> >> I can't runtime test this myself, but it certainly looks like this would >> do the right thing because it calls the core now call the very same >> function as this used to, so: >> >> Reviewed-by: Thierry Reding <treding@xxxxxxxxxx> >> >> Adding Tony and linux-omap for a slightly wider audience and hopefully >> find someone to test this on. For reference, the whole series is here: >> >> https://patchwork.kernel.org/project/linux-mmc/list/?series=66905 > > Thanks Kishon can you please review and test? > I can help with testing once Thomas posts a v2. Thanks, Faiz
