On Tue, Jan 15, 2019 at 05:28:35PM +0100, Thomas Petazzoni wrote: > Even though SDHCI controllers may have a dedicated WP pin that can be > queried using the SDHCI_PRESENT_STATE register, some platforms may > chose to use a separate regular GPIO to route the WP signal. Such a > GPIO is typically represented using the wp-gpios property in the > Device Tree. > > Unfortunately, the current sdhci_check_ro() function does not make use > of such GPIO when available: it either uses a host controller specific > ->get_ro() operation, or uses the SDHCI_PRESENT_STATE. Several host > controller specific ->get_ro() functions are implemented just to use > check a WP GPIO state. "use check" was probably meant to be just "check"? > > Instead of pushing this to more controller-specific implementations, > let's handle this in the core SDHCI code, just like it is already done > for the CD GPIO in sdhci_get_cd(). > > The below patch simply changes sdhci_check_ro() to use the value of > the WP GPIO if available. We need to adjust the prototype of the > function to use a mmc_host* as argument instead of sdhci_host*, since > the mmc_can_gpio_ro() and mmc_gpio_get_ro() helpers take a mmc_host*. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> > --- > drivers/mmc/host/sdhci.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Other than the typo in the commit message, this looks fine: Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
