On Thu, Jan 10, 2019 at 12:13:36PM +0000, Jon Hunter wrote: > On 09/01/2019 18:36, Mark Brown wrote: > > On Tue, Jan 08, 2019 at 05:28:14PM +0000, Jon Hunter wrote: > >> - struct snd_soc_dai_link_component *platform; > >> + struct snd_soc_dai_link_component platform; > > This breaks the build for the SCU cards (and we needs a little rebase > > against another fix I just merged, though I did do that when applying). > Sorry I still don't see the build break, can you point me to it? I'd need to find your patch again and fix the rebase issue. It was assigning a pointer to a platform IIRC. > > I do think that this is going to be the safest thing to do for v5.0, it > > can always be reverted later on when it's not needed but it seems clear > > that a better fix is going to be way too invasive for the -rcs. Can you > > respin and retest please? > Yes will do. I do wonder if we should be concerned about > snd_soc_init_multicodec() as well? Looks like it could have a different > problem if a machine driver already allocated the memory for the codec > link component. Since you appear to be volunteering to check... :)
Attachment:
signature.asc
Description: PGP signature
