Re: [PATCH v2 1/5] arm64: tegra: Add support for NVIDIA Shield TV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 09, 2019 at 09:24:16AM +0800, Mark Zhang wrote:
> Add initial device-tree support for NVIDIA Shield TV (a.k.a. Darcy)
> based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.
> 
> Signed-off-by: Mark Zhang <markz@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/nvidia/Makefile           |  1 +
>  .../dts/nvidia/tegra210-p2894-0050-a08.dts    | 10 +++
>  .../arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 77 +++++++++++++++++++
>  3 files changed, 88 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dts
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi
> 
> diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/nvidia/Makefile
> index 7c13d7df484e..6b8ab5568481 100644
> --- a/arch/arm64/boot/dts/nvidia/Makefile
> +++ b/arch/arm64/boot/dts/nvidia/Makefile
> @@ -4,5 +4,6 @@ dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
> +dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2894-0050-a08.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186-p2771-0000.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra194-p2972-0000.dtb
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dts b/arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dts
> new file mode 100644
> index 000000000000..57bf5ccd30e4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dts
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/dts-v1/;
> +
> +#include "tegra210.dtsi"
> +#include "tegra210-p2894.dtsi"

There's no need to include tegra210.dtsi above because it's already
pulled in by tegra210-p2894.dtsi.

> +
> +/ {
> +	model = "NVIDIA Shield TV";
> +	compatible = "nvidia,darcy", "nvidia,tegra210";

Perhaps we should add another compatible string here that defines the
exact type of board:

	compatible = "nvidia,p2894-0050-a08", "nvidia,darcy", "nvidia,tegra210";

?

Thierry

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux