Quoting Thierry Reding (2018-12-13 08:07:46) > On Thu, Dec 13, 2018 at 02:09:01AM -0800, Stephen Boyd wrote: > > Quoting Jon Hunter (2018-12-13 01:46:14) > > > When CONFIG_SMP is disabled, the tegra clk driver now fails to build: > > > > > > drivers/clk/tegra/clk-tegra30.c: In function ‘tegra30_cpu_rail_off_ready’: > > > drivers/clk/tegra/clk-tegra30.c:1151:2: error: implicit declaration of function ‘tegra_pmc_cpu_is_powered’ [-Werror=implicit-function-declaration] > > > cpu_pwr_status = tegra_pmc_cpu_is_powered(1) || > > > ^ > > > Fix the above error by removing the CONFIG_SMP ifdef around the > > > declaration around the PMC CPU APIs because although these are not > > > needed for non-SMP configurations, there is no harm in including these > > > for non-SMP builds either. > > > > > > Fixes: 61866523ed6e ("clk: tegra30: Use Tegra CPU powergate helper function") > > > Reported-by: Arnd Bergmann <arnd@xxxxxxxx> > > > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > > > > Can I pick this into clk tree? That would make the compilation bisection > > hole very small. I could even reorder the clk-tegra branch to have this > > before the user so the bisection hole doesn't exist. > > Fine with me: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> Ok thanks. I'll reorder things soon, but for now I'll just pick this atop the tegra branch and merge it up to next.