Re: [PATCH 3/4] firmware: tegra: add bpmp driver for Tegra210

[Sivaram Nair <sivaramn@xxxxxxxxxx>]

On Wed, Dec 12, 2018 at 09:31:27PM +0200, Timo Alho wrote:
> +}
> +
> +static irqreturn_t rx_irq(int irq, void *data)

s/rx_irq/tegra210_bpmp_rx_irq/?

> @@ -793,6 +799,7 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
>  static SIMPLE_DEV_PM_OPS(tegra_bpmp_pm_ops, NULL, tegra_bpmp_resume);
>  
>  extern struct tegra_bpmp_ops tegra186_bpmp_ops;
> +extern struct tegra_bpmp_ops tegra210_bpmp_ops;

Move to bpmp-private.h?