Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/12/18 12:19 PM, Sagi Grimberg wrote:

  struct nvme_sgl_desc {
      __le64    addr;
-    __le32    length;
+    __le64    length;
      __u8    rsvd[3];
      __u8    type;
  };

Isn't this a device or protocol defined datastructure?  You can't just
change it like this.

You're correct, we can't...
[Replied before seeing this issue was already highlighted]

The positive side is that it can safely be removed without affecting the
rest of the patch...

Ohh, I am not aware of this protocol defined data-structures. But it seems that this need not be changed as Sagi is saying sg length for NVME
will never cross 32 bit size.
I'll send a new version removing this change. Thanks.




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux