On Tue, Dec 11, 2018 at 11:01:07AM +0800, Mark Zhang wrote: > All comments make sense and will be addressed in next version, thanks > Thierry. > > BTW, I saw that "enable-active-high" and "gpio-open-drain" have been > removed from fixed regulator driver. It seems that they will be handled > in gpiolib so I guess it should not have impact on DTS? Anyway let me > know if dts needs to be changed as well. Looks to me like enable-active-high is handled in of_gpio_flags_quirks() and gpio-open-drain is completely ignored for "regulator-fixed". I think the enable-active-high should stay, but from the above it sounds like it should all still work if you just remove "gpio-open-drain". Thierry
Attachment:
signature.asc
Description: PGP signature
