On Mon, Dec 10, 2018 at 05:43:56PM +0800, Mark Zhang wrote:
> Add gpio-keys nodes for the power button.
>
> Signed-off-by: Mark Zhang <markz@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi
> index ac52286ab9ab..1053f18cc4ae 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
>
> +#include <dt-bindings/input/input.h>
> #include "tegra210.dtsi"
>
> / {
> @@ -52,6 +53,20 @@
> };
> };
>
> + gpio-keys {
> + compatible = "gpio-keys";
> + gpio-keys,name = "gpio-keys";
This property is not only undocumented, it's also unsupported. Let's
just drop it. Bonus points for sending in a patch that removes the only
other occurrence of this from:
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
Also, the Shield TV has an LED that's on when the device is powered on,
does that happen automatically in hardware, or would that be done as a
GPIO (or LED) as well?
Thierry
Attachment:
signature.asc
Description: PGP signature
