On 17/10/2018 17:47, Timo Alho wrote:
>
>
> On 17.10.2018 13.09, Jonathan Hunter wrote:
>>
>> On 17/10/2018 07:37, Timo Alho wrote:
>>> +
>>> + ret = tegra_bpmp_transfer(bpmp, &msg);
>>> + if (ret != 0 || msg.rx.ret != 0) {
>>> + /* something went wrong; assume not supported */
>>> + dev_warn(bpmp->dev, "tegra_bpmp_transfer failed\n");
>>
>> Should we make this a dev_dbg? I am wondering if we want to avoid this
>> print in the case of someone using and older version of the firmware
>> where this is not a critical error? In other words, should the caller of
>> this function be responsible for printing any error messages?
>
> This warning gets printed only when there is an error in communication
> between CPU and BPMP-FW.
>
> For cases where communication was successful, but MRQ is not supported,
> it would be responsibility of the caller to print something if that
> would be useful or needed.
OK great, then that's fine.
Cheers
Jon
--
nvpublic
