On Tue, 25 Sep 2018, Mikko Perttunen wrote: > I'm not the maintainer, but in line with previous similar patches.. > > NAK: this makes the code harder to read. If people don't like it, I wonder if it is a good thing for the function to even exist? Or at least the semantic patch that suggests this could be removed. julia > > Thanks, > Mikko > > On 25/09/2018 10.35, YueHaibing wrote: > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > --- > > drivers/gpu/drm/tegra/drm.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c > > index e22352c..056f749 100644 > > --- a/drivers/gpu/drm/tegra/drm.c > > +++ b/drivers/gpu/drm/tegra/drm.c > > @@ -497,10 +497,7 @@ static int tegra_gem_create(struct drm_device *drm, > > void *data, > > bo = tegra_bo_create_with_handle(file, drm, args->size, args->flags, > > &args->handle); > > - if (IS_ERR(bo)) > > - return PTR_ERR(bo); > > - > > - return 0; > > + return PTR_ERR_OR_ZERO(bo); > > } > > static int tegra_gem_mmap(struct drm_device *drm, void *data, > > > > > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > >
