On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote:
> - dev_err(&pdev->dev, "could not get codec-reset GPIO\n");
> + dev_err(&pdev->dev, "could not get codec-reset GPIO: "
> + "%d\n", ret);
Don't split strings over lines like this, it causes problems when people
grep for errors. It's better to go over 80 columns.
> ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> "nvidia,codec-sync-gpio", 0);
> if (!gpio_is_valid(ac97->sync_gpio)) {
> - dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
> + ret = ac97->sync_gpio;
> + dev_err(&pdev->dev, "no codec-sync GPIO supplied: %d\n", ret);
> goto err_clk_put;
> }
This isn't reporting an error code associated with the attempt to find a
codec-sync GPIO, it's the result of some other operation.
Attachment:
signature.asc
Description: PGP signature
