On Fri, May 04, 2018 at 03:08:43AM +0300, Dmitry Osipenko wrote: > Older Tegra's do not support planes z position handling in hardware, > but HW provides knobs for zPos implementation in software. > > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > drivers/gpu/drm/tegra/dc.c | 134 ++++++++++++++++------- > drivers/gpu/drm/tegra/plane.c | 193 ++++++++++++++++++++++++---------- > drivers/gpu/drm/tegra/plane.h | 13 ++- > 3 files changed, 244 insertions(+), 96 deletions(-) This is obviously a lot to review, but it looks pretty good. On minor comment below. > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 2e81142281c3..ba5481cd470d 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -162,29 +162,90 @@ static void tegra_plane_setup_blending_legacy(struct tegra_plane *plane) [...] > + case 1: > + /* > + * When both middle and topmost windows have an alpha, > + * these windows a mixed together and then the result > + * is blended over the bottom window. > + */ > + if ((state->blending[0].alpha && > + state->blending[0].top)) There seems to be one pair of parentheses too much here. Thierry
Attachment:
signature.asc
Description: PGP signature
