Re: [PATCH V2] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 03, 2018 at 02:02:48PM +0530, Viresh Kumar wrote:
> With a later commit an instance of the struct device will be added to
> struct genpd and with that the size of the struct tegra_powergate will
> be over 1024 bytes. That generates following warning:
> 
> drivers/soc/tegra/pmc.c:579:1: warning: the frame size of 1200 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> Avoid such warnings by allocating the structure dynamically.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> V2:
> - Based of latest changes.
> - Compile tested only.
> 
> @Jon: This was sent long back[1], but then the genpd series wasn't
> finalized, which is going to get merged [2] very soon now. Can I have
> your Ack for this patch so that I can apply it at the beginning of that
> series ?
> 
> [1] https://lkml.kernel.org/r/3fe40fcd427e49cbeac31e14721fea569d230b6e.1490073884.git.viresh.kumar@xxxxxxxxxx
> [2] https://lkml.kernel.org/r/cover.1523273291.git.viresh.kumar@xxxxxxxxxx
> 
>  drivers/soc/tegra/pmc.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux