Looks pretty good to me, a couple of points:
- can you add P3310 to the patch subject, e.g. 'Mark P3310 PHY interrupt
as active low'
- please send the full series to linux-tegra as well
- can you describe in the commit message that this issue wasn't seen
before because the generic PHY driver without interrupt support was used.
Thanks,
Mikko
On 02.05.2018 13:20, Bhadram Varka wrote:
Need to configure PHY gpio interrupt as active low
otherwise it results in spurious interrupts.
Signed-off-by: Bhadram Varka <vbhadram@xxxxxxxxxx>
---
arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi b/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
index a8baad7..13f57ff 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
@@ -46,7 +46,7 @@
compatible = "ethernet-phy-ieee802.3-c22";
reg = <0x0>;
interrupt-parent = <&gpio>;
- interrupts = <TEGRA_MAIN_GPIO(M, 5) IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <TEGRA_MAIN_GPIO(M, 5) IRQ_TYPE_LEVEL_LOW>;
};
};
};
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
