[PATCH] memory: tegra: Remove handling of MC_GART_ERROR_REQ on Tegra20

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



MC_GART_ERROR_REQ register lays inside of GART registers area and MC
happen to access it without issues only by chance. Proper fix would
require integration of MC driver with the GART (will come later), that
would a bit more invasive change than this patch that removes reporting
of faulty client and GART's address that it tries to access.

Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
---

Thierry, please squash this patch into "memory: tegra: Squash tegra20-mc
into common tegra-mc driver", thanks.

 drivers/memory/tegra/mc.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index 6b211daa99bf..c81d01caf1a8 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -38,7 +38,6 @@
 
 #define MC_ERR_ADR 0x0c
 
-#define MC_GART_ERROR_REQ		0x30
 #define MC_DECERR_EMEM_OTHERS_STATUS	0x58
 #define MC_SECURITY_VIOLATION_STATUS	0x74
 
@@ -576,15 +575,8 @@ static __maybe_unused irqreturn_t tegra20_mc_irq(int irq, void *data)
 			break;
 
 		case MC_INT_INVALID_GART_PAGE:
-			reg = MC_GART_ERROR_REQ;
-			value = mc_readl(mc, reg);
-
-			id = (value >> 1) & mc->soc->client_id_mask;
-			desc = error_names[2];
-
-			if (value & BIT(0))
-				direction = "write";
-			break;
+			dev_err_ratelimited(mc->dev, "%s\n", error);
+			continue;
 
 		case MC_INT_SECURITY_VIOLATION:
 			reg = MC_SECURITY_VIOLATION_STATUS;
-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux