Re: [PATCH V7 2/4] PCI: tegra: Add loadable kernel module support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13-Feb-18 7:21 PM, Thierry Reding wrote:
> On Tue, Feb 13, 2018 at 06:48:49PM +0530, Manikanta Maddireddy wrote:
>>
>>
>> On 13-Feb-18 6:37 PM, Thierry Reding wrote:
>>> On Tue, Jan 30, 2018 at 10:54:09AM +0530, Manikanta Maddireddy wrote:
>>>> Implement remove callback function for Tegra PCIe driver to add
>>>> loadable kernel module support. Change PCI_TEGRA config to tristate to
>>>> allow pci-tegra driver to be build as a module.
>>>>
>>>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
>>>> Acked-by: Thierry Reding <treding@xxxxxxxxxx>
>>>> ---
>>>> V2:
>>>> * no change in this patch
>>>> V3:
>>>> * use tegra_pcie_debugfs_exit() helper function in tegra_pcie_debugfs_init()
>>>> V4:
>>>> * no change in this patch
>>>> V5:
>>>> * Decoupled from https://patchwork.ozlabs.org/patch/832053/ and
>>>> rebased on linux-next
>>>> V6:
>>>> * no change in this patch
>>>> V7:
>>>> * no change in this patch
>>>>
>>>>  drivers/pci/host/Kconfig     |  2 +-
>>>>  drivers/pci/host/pci-tegra.c | 34 +++++++++++++++++++++++++++++++---
>>>>  2 files changed, 32 insertions(+), 4 deletions(-)
>>>
>>> Trying to build this as a module I get a link failure because
>>> irq_set_msi_desc() is not exported. I thought a patch to do that had
>>> been part of an earlier version of this series. Has that not been merged
>>> yet?
>>>
>>> Thierry
>>>
>> I got a review comment to use generic MSI model instead of deprecated API.
>> source: https://patchwork.ozlabs.org/patch/841111/
>>
>> Also arm32 compilation will fail because of missing EXPORT of
>> tegra_cpuidle_pcie_irqs_in_use()
>> source: https://patchwork.ozlabs.org/patch/841119/
>>
>> I need to put some time to prepare patches for these two cases.
>> Meanwhile I want to get the basic driver structure for LKM to be merged.
>> I verified locally with these two symbols exported.
> 
> Okay, that's fine. However, you can't request these patches to be merged
> if they will break builds. There are people that run automated builders
> that will check random configurations, which is bound to eventually get
> us a bug report about how this fails to build.
> 
> Perhaps in order to get loadable module support merged without these
> issues you could omit the Kconfig change making this a tristate symbol.
> That way we can get all the structural changes ready and you can work
> on the necessary exports or MSI model patches so that we can eventually
> flip the symbol to tristate.
> 
> By the way, if you do respin for the tristate change, do you mind taking
> a look at the blank line changes for readability I mentioned earlier?
> 
> Thierry
> 

Hi Thierry,

Taken care of both and published V8. Since these are simple changes,
I retained your Ack & Tested signoff.

Manikanta
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux