Re: [PATCH V6 5/7] ata: ahci_tegra: disable devslp for t124

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>

On 01/09/2018 09:17 AM, Preetham Chandru Ramchandra wrote:
From: Preetham Ramchandra <pchandru@xxxxxxxxxx>

t124 does not support devslp and it should be
disabled.

Signed-off-by: Preetham Chandru R <pchandru@xxxxxxxxxx>
---
  drivers/ata/ahci_tegra.c | 29 +++++++++++++++++++++++++++++
  1 file changed, 29 insertions(+)

diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 90dfa803607e..a59a97b1b2e5 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -145,6 +145,10 @@
  #define FUSE_SATA_CALIB					0x124
  #define FUSE_SATA_CALIB_MASK				0x3
+enum {
+	NO_DEVSLP	= (1 << 0),
+};
+
  struct sata_pad_calibration {
  	u8 gen1_tx_amp;
  	u8 gen1_tx_peak;
@@ -166,12 +170,14 @@ struct tegra_ahci_ops {
  struct tegra_ahci_soc {
  	const char *const	*supply_names;
  	u32			num_supplies;
+	u32			quirks;
  	struct tegra_ahci_ops	ops;
  };
struct tegra_ahci_priv {
  	struct platform_device	   *pdev;
  	void __iomem		   *sata_regs;
+	void __iomem		   *sata_aux_regs;
  	struct reset_control	   *sata_rst;
  	struct reset_control	   *sata_oob_rst;
  	struct reset_control	   *sata_cold_rst;
@@ -185,6 +191,18 @@ static const char *const tegra124_supply_names[] = {
  	"avdd", "hvdd", "vddio", "target-5v", "target-12v"
  };
+static void tegra_ahci_handle_quirks(struct ahci_host_priv *hpriv)
+{
+	struct tegra_ahci_priv *tegra = hpriv->plat_data;
+	u32 val;
+
+	if (tegra->sata_aux_regs && (tegra->soc_data->quirks & NO_DEVSLP)) {
+		val = readl(tegra->sata_aux_regs + SATA_AUX_MISC_CNTL_1_0);
+		val &= ~SATA_AUX_MISC_CNTL_1_0_SDS_SUPPORT;
+		writel(val, tegra->sata_aux_regs + SATA_AUX_MISC_CNTL_1_0);
+	}
+}
+
  static int tegra124_ahci_init(struct ahci_host_priv *hpriv)
  {
  	struct tegra_ahci_priv *tegra = hpriv->plat_data;
@@ -232,6 +250,7 @@ static int tegra124_ahci_init(struct ahci_host_priv *hpriv)
  static const struct tegra_ahci_soc tegra124_ahci_soc_data = {
  	.supply_names = tegra124_supply_names,
  	.num_supplies = ARRAY_SIZE(tegra124_supply_names),
+	.quirks = NO_DEVSLP,
  	.ops = {
  		.init = tegra124_ahci_init,
  	},
@@ -412,6 +431,7 @@ static int tegra_ahci_controller_init(struct ahci_host_priv *hpriv)
  	val &= ~SATA_CONFIGURATION_0_CLK_OVERRIDE;
  	writel(val, tegra->sata_regs + SATA_CONFIGURATION_0);
+ tegra_ahci_handle_quirks(hpriv); /* Unmask SATA interrupts */ @@ -485,6 +505,15 @@ static int tegra_ahci_probe(struct platform_device *pdev)
  	tegra->sata_regs = devm_ioremap_resource(&pdev->dev, res);
  	if (IS_ERR(tegra->sata_regs))
  		return PTR_ERR(tegra->sata_regs);
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
+	/*
+	 * Aux register is optional.
+	 */
+	if (res) {
+		tegra->sata_aux_regs = devm_ioremap_resource(&pdev->dev, res);
+		if (IS_ERR(tegra->sata_aux_regs))
+			return PTR_ERR(tegra->sata_aux_regs);
+	}
tegra->sata_rst = devm_reset_control_get(&pdev->dev, "sata");
  	if (IS_ERR(tegra->sata_rst)) {

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux