On 11.12.2017 12:37, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: >> Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to >> dev_err() and use common errors message formatting across the driver for >> consistency. >> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> drivers/usb/phy/phy-tegra-usb.c | 72 +++++++++++++++++++++++++---------------- >> 1 file changed, 44 insertions(+), 28 deletions(-) > > Can we also get rid of all the function names in error messages? I see > that for some error messages you've removed them, but then for others > you added them, so you remove inconsistencies on one hand and add other > inconsistencies at the same time. =) I've removed function names where they aren't useful and added where they are. Of course we can change the error message instead of using function name to give a clue from where in the code error is originated. I'll remove function names in v2. > Other than that, I like this. Thanks ;) -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
