On 30/11/17 13:24, Dmitry Osipenko wrote: > On 30.11.2017 14:31, Jon Hunter wrote: >> >> On 29/11/17 23:13, Dmitry Osipenko wrote: >>> On 30.11.2017 01:55, Jon Hunter wrote: >> >> ... >> >>> I've asked you to re-test Tegra114/124 or whatever was failing for you with the >>> PLL_M being marked as critical instead of PCLK. Maybe it was PLL_M that actually >>> caused trouble on Tegra114/124. >> >> Please share the exact change you would like me to test and I will. > > Please try this: I tried the patch, but this does not work for Tegra124 it still hangs. Tracing the clk calls the last thing I see is ... [ 2.687846] tegra124-dfll 70110000.clock: couldn't get vdd_cpu regulator [ 2.694403] clk_prepare: hclk_div [ 2.695929] clk_prepare_complete: hclk_div [ 2.700027] clk_prepare: hclk [ 2.702947] clk_prepare_complete: hclk [ 2.706673] clk_prepare: pclk_div [ 2.709986] clk_prepare_complete: pclk_div [ 2.714039] clk_prepare: pclk [ 2.716985] clk_prepare_complete: pclk [ 2.720739] clk_prepare: apbdma [ 2.723833] clk_prepare_complete: apbdma [ 2.727736] clk_enable: hclk_div [ 2.730940] clk_enable_complete: hclk_div [ 2.734926] clk_enable: hclk [ 2.737788] clk_enable_complete: hclk [ 2.741426] clk_enable: pclk_div [ 2.744633] clk_enable_complete: pclk_div [ 2.748619] clk_enable: pclk [ 2.751481] clk_enable_complete: pclk [ 2.755120] clk_enable: apbdma [ 2.758153] clk_enable_complete: apbdma [ 2.762390] clk_disable: apbdma [ 2.765088] clk_disable_complete: apbdma [ 2.768986] clk So I believe this change is correct and that Peter's analysis on IRC seems correct, that this change has exposed another issue with the clock driver. Peter, can you summarise which other clocks should be made critical? Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
