Hi Thierry, Linus, On 11/07/2017 12:15 PM, Thierry Reding wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > In order to consolidate the multiple ways to associate an IRQ chip with > a GPIO chip, move more fields into the new struct gpio_irq_chip. > I'd like to report possible issue related to irq.valid_mask in case if drivers which are using it will switch to use gpio_irq_chip and new infra. Now irq.valid_mask is used the following way: - gpiochip_add_data() -- It will allocate irq.valid_mask - driver fills irq.valid_mask if required - driver calls gpiochip_irqchip_add() which will take into account irq.valid_mask and prevents mapping of invalid IRQs With current infra gpio irqchip will be created and initialized from gpiochip_add_data and drivers have no possibility to fill it before that. Again, for now this is "possible issue". > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > --- > Documentation/gpio/driver.txt | 4 ++-- > drivers/gpio/gpio-aspeed.c | 4 ++-- > drivers/gpio/gpio-stmpe.c | 4 ++-- > drivers/gpio/gpiolib.c | 16 ++++++++-------- > drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++-- > drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++-- > drivers/platform/x86/intel_int0002_vgpio.c | 4 ++-- > include/linux/gpio/driver.h | 21 +++++++++++++++------ > 8 files changed, 35 insertions(+), 26 deletions(-) > > diff --git a/Documentation/gpio/driver.txt b/Documentation/gpio/driver.txt > index dcf6af1d9e56..d8de1c7de85a 100644 > --- a/Documentation/gpio/driver.txt > +++ b/Documentation/gpio/driver.txt > @@ -313,8 +313,8 @@ symbol: > mark all the child IRQs as having the other IRQ as parent. > > If there is a need to exclude certain GPIOs from the IRQ domain, you can > -set .irq_need_valid_mask of the gpiochip before gpiochip_add_data() is > -called. This allocates an .irq_valid_mask with as many bits set as there > +set .irq.need_valid_mask of the gpiochip before gpiochip_add_data() is > +called. This allocates an .irq.valid_mask with as many bits set as there > are GPIOs in the chip. Drivers can exclude GPIOs by clearing bits from this > mask. The mask must be filled in before gpiochip_irqchip_add() or > gpiochip_irqchip_add_nested() is called. > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c ,... -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
