On 06.07.2017 04:23, Peter Chen wrote: > On Wed, Jul 05, 2017 at 08:19:52PM +0300, Dmitry Osipenko wrote: >> + /* setup and register ChipIdea HDRC device */ >> + udc->data.name = "tegra-udc"; >> + udc->data.capoffset = DEF_CAPOFFSET; >> + udc->data.flags = 0; >> + udc->data.usb_phy = udc->phy; >> + >> + /* setup device specific quirks */ >> + soc = id->data; >> + >> + if (!soc->supports_unaligned_dma) >> + udc->data.flags |= CI_HDRC_REQUIRES_ALIGNED_DMA; >> + >> + /* power on UDC controller */ >> + usb_phy_set_suspend(udc->phy, 0); > > Why above is needed? The chipidea core will do usb_phy_init for power > on. > It is needed because Tegra's USB PHY driver doesn't hook up .init() of the struct usb_phy and the power management is handled by set_suspend(). -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
