>-----Original Message----- >From: Mikko Perttunen [mailto:cyndis@xxxxxxxx] >Sent: Sunday, May 14, 2017 4:59 PM >To: Preetham Chandru <pchandru@xxxxxxxxxx>; thierry.reding@xxxxxxxxx; >tj@xxxxxxxxxx >Cc: tegra@xxxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; Laxman Dewangan ><ldewangan@xxxxxxxxxx>; preetham260@xxxxxxxxx; Venu Byravarasu ><vbyravarasu@xxxxxxxxxx>; Pavan Kunapuli <pkunapuli@xxxxxxxxxx>; linux- >tegra@xxxxxxxxxxxxxxx >Subject: Re: [PATCH V3 3/3] arm64: tegra: Enable SATA on Tegra210 > >On 05/12/2017 12:56 PM, Preetham Chandru wrote: >> +CC linux-tegra@xxxxxxxxxxxxxxx >> >>> -----Original Message----- >>> From: Preetham Chandru >>> Sent: Friday, May 12, 2017 3:04 PM >>> To: thierry.reding@xxxxxxxxx; tj@xxxxxxxxxx >>> Cc: tegra@xxxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; Laxman Dewangan >>> <ldewangan@xxxxxxxxxx>; preetham260@xxxxxxxxx; Venu Byravarasu >>> <vbyravarasu@xxxxxxxxxx>; Pavan Kunapuli <pkunapuli@xxxxxxxxxx>; >>> Preetham Chandru <pchandru@xxxxxxxxxx> >>> Subject: [PATCH V3 3/3] arm64: tegra: Enable SATA on Tegra210 >>> >>> From: Preetham Chandru R <pchandru@xxxxxxxxxx> >>> >>> Enable the SATA unit on Tegra210 systems. >>> >>> Signed-off-by: Preetham Chandru R <pchandru@xxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 6 ++++++ >>> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 16 ++++++++++++++++ >>> 2 files changed, 22 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi >>> b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi >>> index e5fc67b..58c28b9 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi >>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi >>> @@ -1324,6 +1324,12 @@ >>> status = "okay"; >>> }; >>> >>> + sata@70020000 { >>> + status = "okay"; >>> + phys = <&{/padctl@7009f000/pads/sata/lanes/sata-0}>; >>> + phy-names = "sata-0"; >>> + }; >>> + >>> padctl@7009f000 { >>> status = "okay"; >>> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>> b/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>> index 8f26c4d..20c9160 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi >>> @@ -795,6 +795,22 @@ >>> #iommu-cells = <1>; >>> }; >>> >>> + sata@70020000 { >>> + compatible = "nvidia,tegra210-ahci"; >>> + reg = <0x0 0x70027000 0x0 0x2000>, /* AHCI */ >>> + <0x0 0x70020000 0x0 0x7000>, /* SATA */ >>> + <0x0 0x70001100 0x0 0x1000>; /* SATA AUX*/ > >Missing space after 'AUX' > Okay. >>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; >>> + clocks = <&tegra_car TEGRA210_CLK_SATA>, >>> + <&tegra_car TEGRA210_CLK_SATA_OOB>; >>> + clock-names = "sata", "sata-oob"; >>> + resets = <&tegra_car 124>, >>> + <&tegra_car 123>, >>> + <&tegra_car 129>; >>> + reset-names = "sata", "sata-oob", "sata-cold"; > >The binding documentation says that sata-cold is not required for tegra210? > It's a mistake in binding documentation. Will correct it in binding doc. >>> + status = "disabled"; >>> + }; >>> + >>> hda@70030000 { >>> compatible = "nvidia,tegra210-hda", "nvidia,tegra30-hda"; >>> reg = <0x0 0x70030000 0x0 0x10000>; >>> -- >>> 2.1.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-tegra" >> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo >> info at http://vger.kernel.org/majordomo-info.html >> -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
