Le mardi 18 avril 2017 à 10:15 -0600, Stephen Warren a écrit : > On 04/18/2017 09:11 AM, Paul Kocialkowski wrote: > > This selects the tegra30 i2s and ahub controllers for the tegra124 SoC. > > These are needed when building without ARCH_TEGRA_3x_SOC set. > > diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig > > index efbe8d4c019e..bcd18d2cf7a7 100644 > > --- a/sound/soc/tegra/Kconfig > > +++ b/sound/soc/tegra/Kconfig > > @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF > > > > config SND_SOC_TEGRA30_AHUB > > tristate > > - depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC > > + depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || > > ARCH_TEGRA_124_SOC) > > Is this really a compile-time dependency? From a quick look at the code, I doubt this is really a build dependency. > If so, don't we need to add T210 and T186 entries into that || condition too, > since we could be building a kernel with just T210/T186 support and no T124 > support? In the spirit of this patch, adding entries for other tegra platforms would make sense. Would you prefer that we leave out the dependency from SND_SOC_TEGRA30_* and only select the right I2S driver to use in each codec driver? If not, we'd have to list all relevant platforms both in the I2S/AHUB drivers and in each codec's rules (which is not necessarily and issue, but there's no need to have artificial platform dependencies). What do you think? -- Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
Attachment:
signature.asc
Description: This is a digitally signed message part
