On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: > On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: > >> On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi <smangipudi@xxxxxxxxxx> wrote: > >> > >> > Add GPIO driver for T186 based platforms. > >> > Adds support for MAIN and AON GPIO's from T186. > >> > > >> > Signed-off-by: Suresh Mangipudi <smangipudi@xxxxxxxxxx> > >> > >> Stephen/Thierry/Alexandre: > >> Can I get your review on this Tegra thing? > > > > Can we hold off on this for a bit? I've got my own implementation of > > this in my Tegra186 tree because I thought nobody else was working on > > it. From a brief look they seem mostly similar but there are a couple > > of differences that I need to take a closer look at (and do some more > > intensive testing on). > > Be careful about discouraging other developers internally from > participating upstream, Thierry. That was certainly not my intention. I do welcome any contributions, internal or external. > Please don't become a bottleneck for your company's contributions. > Rewriting stuff on your own isn't a scalable model. Like I said, I didn't rewrite this, I merely wrote the GPIO driver because there wasn't one at the time and I wasn't aware of anyone else working on one. Waiting for a GPIO driver to emerge would've prevented me from making progress on other fronts. Thierry
Attachment:
signature.asc
Description: PGP signature
