Re: [PATCH tegra-uboot-scripts] Use full U-Boot command names in all cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/06/2016 10:18 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@xxxxxxxxxx>
> 
> The generated U-Boot script currently invokes "set" as a U-Boot command.
> This is intended to be an abbreviation for "setenv". This works fine when
> there are no other commands named "set*", but fails when there are. Use
> the full command name to avoid issues.
> 
> Reported-by: Aaron Plattner <aplattner@xxxxxxxxxx>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> ---
> Note that I haven't tested this; if you could that'd be great.

This is identical to what I applied locally, so
Reviewed-by: Aaron Plattner <aplattner@xxxxxxxxxx>
Tested-by: Aaron Plattner <aplattner@xxxxxxxxxx>

> 
>  gen-uboot-script.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gen-uboot-script.py b/gen-uboot-script.py
> index e11dbf15553c..6db377d96c07 100755
> --- a/gen-uboot-script.py
> +++ b/gen-uboot-script.py
> @@ -132,13 +132,13 @@ else:
>  
>  f.write('''\
>  if test -n "${fdtfile}"; then
> -    set _fdt ${fdtfile};
> +    setenv _fdt ${fdtfile};
>  else
> -    set _fdt ${soc}-${board}${boardver}.dtb;
> +    setenv _fdt ${soc}-${board}${boardver}.dtb;
>  fi
>  ''')
>  f.write(load + ' ${fdt_addr_r} ' + args.dtbdir + '${_fdt}\n')
> -f.write('set _fdt\n')
> +f.write('setenv _fdt\n')
>  
>  bootargs = ''
>  if not args.no_con_ttyS0:
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux