On 28/08/16 18:32, Paul Kocialkowski wrote: > This switches a few interrupt definitions that were using > GPIO_ACTIVE_HIGH as IRQ type, which is invalid. May be you are right, but this does not describe why this is invalid. Can you elaborate? > Signed-off-by: Paul Kocialkowski <contact@xxxxxxxx> > --- > arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi > index 271505e..30a77ec 100644 > --- a/arch/arm/boot/dts/tegra124-nyan.dtsi > +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi > @@ -59,7 +59,7 @@ > compatible = "maxim,max98090"; > reg = <0x10>; > interrupt-parent = <&gpio>; > - interrupts = <TEGRA_GPIO(H, 4) GPIO_ACTIVE_HIGH>; > + interrupts = <TEGRA_GPIO(H, 4) IRQ_TYPE_EDGE_FALLING>; If this in invalid then the DT binding doc for the max98090 should be updated as well. > }; > > temperature-sensor@4c { > @@ -325,7 +325,7 @@ > reg = <0x9>; > interrupt-parent = <&gpio>; > interrupts = <TEGRA_GPIO(J, 0) > - GPIO_ACTIVE_HIGH>; > + IRQ_TYPE_EDGE_BOTH>; > ti,ac-detect-gpios = <&gpio > TEGRA_GPIO(J, 0) > GPIO_ACTIVE_HIGH>; > Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html