Re: [PATCH V2 00/10] PM / Domains: Add support for removing PM domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, September 12, 2016 03:02:13 PM Ulf Hansson wrote:
> On 12 September 2016 at 13:01, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
> > In order to safely remove PM domains there are a few changes that need to be
> > made to ensure that no one is holding an external reference to a PM domain
> > after it has been removed. One solution, implemented here, solves this by
> > eliminating external references to PM domain.
> >
> > Changes from V1:
> > - Added test when removing a PM domain to ensure the PM domain provider
> >   has been removed.
> > - Re-organised patches 8-10 so that patch #8 adds the code to verify if
> >   the provider is present, patch #9 adds basic support for removing PM
> >   domains and patch #10 adds support for removing PM domains by provider.
> >
> > Changes from initial RFC:
> > - Renamed functions made static per Ulf's feedback.
> > - Added patch to clean-up provider/xlate APIs per Ulf's feedback
> > - Re-worked and simplified the association between PM domains and PM
> >   domain providers. Dropped the 'provider_data' variable from the
> >   generic_pm_domain structure in favour of using the fwnode_handle.
> > - Split patch for removing PM domains into multiple patches per Ulf's
> >   feedback.
> >
> > Jon Hunter (10):
> >   PM / Domains: Add new helper functions for device-tree
> >   ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()
> >   staging: board: Remove calls to of_genpd_get_from_provider()
> >   PM / Domains: Don't expose generic_pm_domain structure to clients
> >   PM / Domains: Don't expose xlate and provider helper functions
> >   PM / Domains: Verify the PM domain is present when adding a provider
> >   PM / Domains: Prepare for adding support to remove PM domains
> >   PM / Domains: Store the provider in the PM domain structure
> >   PM / Domains: Add support for removing PM domains
> >   PM / Domains: Add support for removing nested PM domains by provider
> >
> >  drivers/base/power/domain.c      | 353 +++++++++++++++++++++++++++++++++++----
> >  drivers/soc/samsung/pm_domains.c |  23 +--
> >  drivers/staging/board/board.c    |   9 +-
> >  include/linux/pm_domain.h        |  74 ++++----
> >  4 files changed, 364 insertions(+), 95 deletions(-)
> >
> > --
> > 2.1.4
> >
> 
> Jon, thanks for being patient and keep working on this series! I have
> now completed the review and I am happy with this version.
> 
> Also, I remember Krzysztof requested an immutable branch for this
> series, I guess Rafael can arrange that if still needed!?

Yes, I can do that.

I think I'll get to these patches later today and if not, then tomorrow.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux