Hi Paul,
On Sat, Sep 03, 2016 at 12:09:53AM +0200, Paul Kocialkowski wrote:
> This requests the status GPIO with initial input setup. it is required
> to read the GPIO status at probe time and thus correctly avoid sending
> i2c messages when AC is not plugged.
>
> When requesting the GPIO without initial input setup, it always reads 0
> which causes probe to fail as it assumes the charger is connected, sends
> i2c messages and fails.
>
> While at it, this switches the driver over to gpio consumer.
>
> Signed-off-by: Paul Kocialkowski <contact@xxxxxxxx>
> ---
> drivers/power/supply/bq24735-charger.c | 44 +++++++++++++---------------------
> include/linux/power/bq24735-charger.h | 4 ----
> 2 files changed, 16 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c
[...]
> - if (IS_ENABLED(CONFIG_OF) && !charger->pdata && client->dev.of_node)
> + if (IS_ENABLED(CONFIG_OF) && !charger->pdata && client->dev.of_node) {
> charger->pdata = bq24735_parse_dt_data(client);
> + if (IS_ERR(charger->pdata))
> + return PTR_ERR(charger->pdata);
> + }
I queued your patch into power-supply's for-next branch, but dropped
this change, which is from an earlier revision of this patch and no
longer needed. Thanks for your patch.
-- Sebastian
Attachment:
signature.asc
Description: PGP signature
