On 09/08/16 08:21, Mirza Krak wrote: > 2016-08-08 15:47 GMT+02:00 Jon Hunter <jonathanh@xxxxxxxxxx>: ... >>> + return of_platform_default_populate(of_node, NULL, dev); >> >> Seems odd to do this here. Why not as the last thing in probe once the >> GMI has been setup correctly? > > It is done here mostly to avoid clean up in probe. I could move it out > of tegra_gmi_parse_dt and put it right after that call but still > before clk enable? Is that less odd? I would have thought that clocks should be enabled and resets de-asserted before we even attempt to populate any children. Hence, I would do this last. Yes that will require some clean-up in probe if this does fail but seems safest. Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
