On 22/07/16 20:18, Mirza Krak wrote: > 2016-07-22 11:38 GMT+02:00 Jon Hunter <jonathanh@xxxxxxxxxx>: >>>> The driver should have a remove function given that we can build as a >>>> module. >>> >>> At the moment I do not know what we would do in a remove function and >>> hence me not adding one. >> >> Should just be the inverse of the probe (although there is no inverse >> for the parsing DT bit). If you don't wish to add a remove, that is >> fine, but make the driver a 'bool' and not 'tristate' in the Kconfig so >> it cannot be configured as a module. > > I understand the concept of a remove function, but I use devm_ calls > for all resources. These should be handled by the device core on a > driver detach? There is one clock that needs to be disabled in the remove. Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
