Re: [PATCH] ALSA: hda/tegra: iomem fixups for sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 22 Jun 2016 14:35:51 +0200,
Thierry Reding wrote:
> 
> On Tue, Jun 21, 2016 at 07:18:32PM +0100, Ben Dooks wrote:
> > The readl/writel are not being passed __iomem annotated
> > variables, so fix the following sparse warnings by adding
> > __iomem in:
> > 
> > sound/pci/hda/hda_tegra.c:120:9: warning: incorrect type in argument 2 (different address spaces)
> > sound/pci/hda/hda_tegra.c:120:9:    expected void volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:120:9:    got unsigned int [usertype] *addr
> > sound/pci/hda/hda_tegra.c:125:16: warning: incorrect type in argument 1 (different address spaces)
> > sound/pci/hda/hda_tegra.c:125:16:    expected void const volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:125:16:    got unsigned int [usertype] *addr
> > sound/pci/hda/hda_tegra.c:134:13: warning: incorrect type in argument 1 (different address spaces)
> > sound/pci/hda/hda_tegra.c:134:13:    expected void const volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:134:13:    got void *dword_addr
> > sound/pci/hda/hda_tegra.c:137:9: warning: incorrect type in argument 2 (different address spaces)
> > sound/pci/hda/hda_tegra.c:137:9:    expected void volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:137:9:    got void *dword_addr
> > sound/pci/hda/hda_tegra.c:146:13: warning: incorrect type in argument 1 (different address spaces)
> > sound/pci/hda/hda_tegra.c:146:13:    expected void const volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:146:13:    got void *dword_addr
> > sound/pci/hda/hda_tegra.c:156:13: warning: incorrect type in argument 1 (different address spaces)
> > sound/pci/hda/hda_tegra.c:156:13:    expected void const volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:156:13:    got void *dword_addr
> > sound/pci/hda/hda_tegra.c:159:9: warning: incorrect type in argument 2 (different address spaces)
> > sound/pci/hda/hda_tegra.c:159:9:    expected void volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:159:9:    got void *dword_addr
> > sound/pci/hda/hda_tegra.c:168:13: warning: incorrect type in argument 1 (different address spaces)
> > sound/pci/hda/hda_tegra.c:168:13:    expected void const volatile [noderef] <asn:2>*addr
> > sound/pci/hda/hda_tegra.c:168:13:    got void *dword_addr
> > sound/pci/hda/hda_tegra.c:173:23: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> > sound/pci/hda/hda_tegra.c:173:23:    expected void ( *reg_writel )( ... )
> > sound/pci/hda/hda_tegra.c:173:23:    got void ( static [toplevel] *<noident> )( ... )
> > sound/pci/hda/hda_tegra.c:174:22: warning: incorrect type in initializer (incompatible argument 1 (different address spaces))
> > sound/pci/hda/hda_tegra.c:174:22:    expected unsigned int ( *reg_readl )( ... )
> > sound/pci/hda/hda_tegra.c:174:22:    got unsigned int ( static [toplevel] *<noident> )( ... )
> > sound/pci/hda/hda_tegra.c:175:23: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> > sound/pci/hda/hda_tegra.c:175:23:    expected void ( *reg_writew )( ... )
> > sound/pci/hda/hda_tegra.c:175:23:    got void ( static [toplevel] *<noident> )( ... )
> > sound/pci/hda/hda_tegra.c:176:22: warning: incorrect type in initializer (incompatible argument 1 (different address spaces))
> > sound/pci/hda/hda_tegra.c:176:22:    expected unsigned short ( *reg_readw )( ... )
> > sound/pci/hda/hda_tegra.c:176:22:    got unsigned short ( static [toplevel] *<noident> )( ... )
> > sound/pci/hda/hda_tegra.c:177:23: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> > sound/pci/hda/hda_tegra.c:177:23:    expected void ( *reg_writeb )( ... )
> > sound/pci/hda/hda_tegra.c:177:23:    got void ( static [toplevel] *<noident> )( ... )
> > sound/pci/hda/hda_tegra.c:178:22: warning: incorrect type in initializer (incompatible argument 1 (different address spaces))
> > sound/pci/hda/hda_tegra.c:178:22:    expected unsigned char ( *reg_readb )( ... )
> > sound/pci/hda/hda_tegra.c:178:22:    got unsigned char ( static [toplevel] *<noident> )( ... )
> > 
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> > ---
> > Cc: Jaroslav Kysela <perex@xxxxxxxx>
> > Cc: Takashi Iwai <tiwai@xxxxxxxx>
> > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> > Cc: alsa-devel@xxxxxxxxxxxxxxxx
> > Cc: linux-tegra@xxxxxxxxxxxxxxx
> > ---
> >  sound/pci/hda/hda_tegra.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> Takashi's already applid it, but fwiw:
> 
> Acked-by: Thierry Reding <treding@xxxxxxxxxx>

I forgot to push (while being in a conference), so now I could merge
your ack, too ;)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux