Re: [PATCH] ARM: tegra: fix missing include <soc/tegra/cpuidle.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/06/16 15:33, Jon Hunter wrote:
> 
> On 10/06/16 15:22, Thierry Reding wrote:
>> * PGP Signed by an unknown key
>>
>> On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
>>> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
>>> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
>>> so add that include to avoid the following warning:
>>>
>>> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
>>> ---
>>> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
>>> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
>>> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
>>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>>> Cc: linux-tegra@xxxxxxxxxxxxxxx
>>> ---
>>>  arch/arm/mach-tegra/cpuidle.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> I've been carrying a set of patches to fix these, and a couple of other
>> sparse warnings, in my tree locally, but never sent them out because
>> they were so trivial. I probably should've to avoid the duplication of
>> effort. Sorry about that.

Given it is likely that gcc warning flags will be updated
it'd be good to get these issues sorted out.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux