Re: [PATCH v3 2/4] thermal: send notifications for tz temperature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/29/2016 05:41 PM, Srikar Srimath Tirumala wrote:
* Update the 'temp' attr of a thermal_zone sysfs node, when the
   temperature goes above\below a trip point. Use sysfs_notify to send
   the notifications.
Rather than notifying temp, would it make sense to notify trip_pointX_temp when temperature crosses the trip point going up and trip_pointX_hyst when temperature crosses the trip point going down? That would allow userspace to watch for only a subset of events by polling/selecting on the relevant nodes.

struct thermal_cooling_device_ops {
@@ -348,6 +358,7 @@ struct thermal_zone_of_device_ops {
   * @temperature: temperature value in miliCelsius
   * @hysteresis: relative hysteresis in miliCelsius
   * @type: trip point type
+ * @state: trip point state
   */
struct thermal_trip {
@@ -355,6 +366,7 @@ struct thermal_trip {
  	unsigned long int temperature;
  	unsigned long int hysteresis;
  	enum thermal_trip_type type;
+	enum thermal_trip_state state;
This looks vestigial. Remove it?


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux