> -----Original Message----- > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > Sent: Monday, March 14, 2016 1:17 PM > To: Jimmy Zhang > Cc: Allen Martin; Stephen Warren; alban.bedel@xxxxxxxxxxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx > Subject: Re: [tegrarcm PATCH V2 3/4] Add option --download-signed-msgs to > download signed blobs > > On 03/14/2016 02:01 PM, Jimmy Zhang wrote: > > > > > >> -----Original Message----- > >> From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > >> Sent: Monday, March 14, 2016 12:18 PM > >> To: Jimmy Zhang > >> Cc: Allen Martin; Stephen Warren; alban.bedel@xxxxxxxxxxxxxxxxx; > >> linux- tegra@xxxxxxxxxxxxxxx > >> Subject: Re: [tegrarcm PATCH V2 3/4] Add option > >> --download-signed-msgs to download signed blobs > >> > >> On 03/11/2016 06:02 PM, Jimmy Zhang wrote: > >>> This feature allows user to download signed messages to devices > >>> secured with PKC. > >>> > >>> Example: > >>> tegrarcm --download-signed-msgs --signed-msgs-file rel_1001.bin \ > >>> --bct=jetson-tk1-bct.bct --bootloader=u-boot.bin > >>> --loadaddr=0x83d88000 > >>> > >>> Where the following blob files are downloaded to device sequentially: > >>> > >>> a) rel_1001.bin.qry > >>> b) rel_1001.bin.ml > >>> c) rel_1001.bin.bl > >> > >>> @@ -1083,14 +1198,24 @@ static int > download_bootloader(nv3p_handle_t > >> h3p, char *filename, > >>> } > >>> > >>> ret = nv3p_data_send(h3p, rsa_pss_sig, > >> sizeof(rsa_pss_sig)); > >>> - if (ret) { > >>> - dprintf("error sending bootloader > >> signature\n"); > >>> + } > >> > >> Doesn't this change (moving that error dprintf later) mean that any > >> error there potentially won't be reported, since the code below can > >> overwrite "ret" before the moved copy of that check? I'm not > >> convinced the code should be moved. > >> > > > > No. This is because only one can be true between pkc_keyfile and > signed_msgs_file. Ie, either when signing on fly or signed without keyfile > option. This logic is ensured in main when checking command line options. > > Ah, I guess that makes sense. Reading the diff is a bit more confusing than > the resultant code. So, this patch, > OK. I think I should add some comments here. Also, add error case if neither conditions are true. > Acked-by: Stephen Warren <swarren@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
