On 2016年01月21日 22:56, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Jan 18, 2016 at 06:02:25PM +0800, Wei Ni wrote: >> This patchset adds following functions for tegra_soctherm driver: >> 1. add T210 support. >> 2. export debugfs to show some registers. >> 3. add thermtrip funciton. >> 4. add suspend/resume function. >> >> The V1 serial is in: >> http://www.spinics.net/lists/linux-tegra/msg24808.html >> The V2 serial is in: >> http://www.spinics.net/lists/linux-tegra/msg24901.html >> >> Main changes from V2: >> 1. Fix build error in patch [1/11]. >> 2. Use of_get_child_by_name instead of of_find_node_by_name in patch [8/11]. >> 3. Use debugfs_remove_recursive to remove debugfs in patch [6/11]. >> >> Main changes from V1: >> 1. Use the new type to handl different Tegra chips in one driver, >> which suggested by Thierry. >> 2. Changes per Thieery's other comments. >> >> Wei Ni (11): >> thermal: tegra: move tegra thermal files into tegra directory >> thermal: tegra: combine sensor group-related data >> thermal: tegra: get rid of PDIV/HOTSPOT hack >> thermal: tegra: split tegra_soctherm driver >> thermal: tegra: add T210-specific SOC_THERM driver >> thermal: tegra: add a debugfs to show registers >> of: Add bindings of hw-trips for soctherm >> thermal: tegra: add thermtrip function >> thermal: tegra: add PM support >> arm64: tegra: add soctherm node for Tegra210 >> ARM: tegra: set hw trips for Tegra124 > > Hi Wei, > > This series looks mostly good to me. I've commented on a couple of minor > things as replies to the individual patches. Thanks for your review, I will check your comments and send out next version in next few days. > > On a higher level, what's the test procedure that we can use to validate > that this code works? You can check following files: 1. Run "cat /sys/class/thermal/thermal*/temp" to read temperature This driver will register four thermal zones: cpu, gpu, mem and pll. 2. Run "cat /sys/kernel/debug/tegra_soctherm/regs" to show the register contents. 3. Write a low temperature value to /sys/kernel/debug/tegra_soctherm/thermtrip/xxx to trigger the thermtrip function. For example, if the cpu temperature is 30000 now, you can read it from above thermal zones, then "echo 25000 > /sys/kernel/debug/tegra_soctherm/thermtrip/cpu", the system will be shutdown immediately. > > Thierry > > * Unknown Key > * 0x7F3EB3A1 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
