Re: [cbootimage PATCH 3/3] Add support to read and write rsa related fields on t124

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/11/2015 09:56 AM, Alban Bedel wrote:
On Wed, 11 Nov 2015 09:41:08 -0700
Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:

On 11/05/2015 09:03 AM, Alban Bedel wrote:
This allow creating and reading signed images for secure boot on t124.

This patch looks like it's identical to the equivalent code for T210.
Does it depend on your other two patches, or is it independent, such
that I can apply it now?

Yes, this can be applied without the rest.

OK, I've applied this patch.

It'd be nice if we could share code between src/tNNN/nvbctlib_tNNN.c
somehow rather than duplicating it all, but that's not a problem this
patch introduces, so no need to attempt that now.

That would be quiet nice, but that would probably require quiet a large
rework of the current abstraction. I suspect it would need to move to
some description of the BCT that include the offset of each field. That
way the parsers/set/get functions wouldn't need to be reimplemented for
each BCT version.

My idea was to compile a single C file once per SoC, with the pre-processor include path set differently each time in order to pick up a per-SoC header containing the definition of the BCT structure type, plus some configuration options to indicate which fields exist in the structure, in order to ifdef out support for missing fields. I've seen this technique used in other places and it worked out well there.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux