Re: [cbootimage PATCH v6 1/5] Add support for update pubkey and rsa-pss signatures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/19/2015 01:03 PM, Jimmy Zhang wrote:
Create new configuration keywords:
    RsaKeyModulusFile: pubkey modulus
    RsaPssSigBlFile:   bootloader rsa pss signature
    RsaPssSigBctFile:  bct rsa pss signature

Sample Configuration file update_bl_sig.cfg
    RsaKeyModulusFile = pubkey.mod;
    RsaPssSigBlFile = bl.sig;

where pubkey.mod and bl.sig are files that contain the public key
modulus and bootloader's rsa-pss signature respectively.

public key modulus and signature are created through utilities
outside cbootimage.

Command line example:
  $ cbootimage -s tegra210 -u update_bl_sig.cfg image.bin image.bin-bl-signed

Above three new keywords added in this CL are only implemented to support
for T210.

Changes in V6:
1) Rename function swap_endianness() to reverse_byte_order()
2) Put "size - 1 - i" to a variable to avoid double calculation
3) Remove checking NULL pointer of get_value_size() in function set_rsa_param()
4) Change function prototype for get_value_size()

The changelog should be below the --- line since it's not typically checked in.

  src/t114/nvbctlib_t114.c |  1 +
  src/t124/nvbctlib_t124.c |  1 +
  src/t210/nvbctlib_t210.c | 46 +++++++++++++++++++++++++++++++++++++++++++++-

t20, t30, t132 files should be updated to add an implementation of struct cbootimage_soc_config .get_value_size too.

I was going to apply these patches and then send a patch to fix that up, but I noticed that this series introduces a bunch of warnings. Can you submit v7 that builds cleanly, has that fixed, and:

diff --git a/src/crypto.c b/src/crypto.c

+void
+reverse_byte_order(
+	u_int8_t *out,
+	u_int8_t *in,

"in" should be const.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux