> -----Original Message----- > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > Sent: Tuesday, October 13, 2015 9:19 AM > To: Jimmy Zhang > Cc: Allen Martin; Stephen Warren; linux-tegra@xxxxxxxxxxxxxxx > Subject: Re: [cbootimage PATCH v5 1/5] Add support for update pubkey and > rsa-pss signatures > > On 10/12/2015 08:02 PM, Jimmy Zhang wrote: > > > > > >> -----Original Message----- > >> From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > >> Sent: Monday, October 12, 2015 3:49 PM > >> To: Jimmy Zhang > >> Cc: Allen Martin; Stephen Warren; linux-tegra@xxxxxxxxxxxxxxx > >> Subject: Re: [cbootimage PATCH v5 1/5] Add support for update pubkey > >> and rsa-pss signatures > >> > >> On 10/09/2015 07:46 PM, Jimmy Zhang wrote: > >>> Create new configuration keywords: > >>> RsaKeyModulusFile: pubkey modulus > >>> RsaPssSigBlFile: bootloader rsa pss signature > >>> RsaPssSigBctFile: bct rsa pss signature > >>> > >>> Sample Configuration file update_bl_sig.cfg > >>> RsaKeyModulusFile = pubkey.mod; > >>> RsaPssSigBlFile = bl.sig; > >>> > >>> where pubkey.mod and bl.sig are files that contain the public key > >>> modulus and bootloader's rsa-pss signature respectively. > >>> > >>> public key modulus and signature are created through utilities > >>> outside cbootimage. > >>> > >>> Command line example: > >>> $ cbootimage -s tegra210 -u update_bl_sig.cfg image.bin > >>> image.bin-bl-signed > >>> > >>> Above three new keywords added in this CL are only implemented > >>> support for T210. > >> > >> I'd like to see a changelog per patch so I don't have to refer back > >> to the cover letter each time. > >> > > > > OK > > > >>> diff --git a/src/crypto.c b/src/crypto.c > >> > >>> +void > >>> +swap_endianness( > >> > >> Nit: It's more like "byte order" (serialization) rather than > >> endianness, although they're related concepts. > > > > This is the function name used by tegrasign. I am open if you have a better > name. The reason for the swap because the string actually is a 256 byte long > number. Tegra soc handles a number by little endian byte order. > > reverse_byte_order()? > > BTW, does cbootimage operate correctly if run in a big-endian host? For this function, it should be no difference. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
