> -----Original Message----- > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > Sent: Monday, October 12, 2015 3:51 PM > To: Jimmy Zhang > Cc: Allen Martin; Stephen Warren; linux-tegra@xxxxxxxxxxxxxxx > Subject: Re: [cbootimage PATCH v5 2/5] Add support to dump rsa related > fields for t210 > > On 10/09/2015 07:46 PM, Jimmy Zhang wrote: > > Add support to dump rsa pubkey, bct's rsa-pss signature and > > bootloader's rsa-pss signature. > > > diff --git a/src/bct_dump.c b/src/bct_dump.c > > > +#define ARSE_RSA_PARAM_MAX_BYTES 256 > > typedef union { > > u_int32_t val; > > u_int8_t uid[16]; > > + u_int8_t rsa_param[ARSE_RSA_PARAM_MAX_BYTES]; > > } param_types; > > Shouldn't that be replaced by something that uses the new get_size() > functionality now implemented in patch 1? For this data structure, I guess we better stay with a MAX constant. For display functions, ie values[i].format(...) bl_values[j].format(...) There is no id token being passed in. To use get_size(), all format_xxx function prototype need to be redefined (by adding in id token). I can submit a new patch if you agree my observations. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
