Re: [tegrarcm PATCH v2 4/4] Add new configuration keyword "ReSignBl"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/07/2015 04:45 PM, Jimmy Zhang wrote:
Stephen Warren wrote at Wednesday, October 07, 2015 10:11 AM:
On 10/02/2015 02:57 PM, Jimmy Zhang wrote:
This feature is needed in case an image is updated at later stage
after it has been created.

How to use:
    Add keyword "ReSignBl" to configuration file, for example resign.cfg:
      ReSignBl;

    Invoke cbootimage to resign image, for example bootloader.bin:
      $ cbootimage -s tegra210 --update resign.cfg bootloader.bin
bootloader.bin-resigned

    Where bootloader.bin-resigned is the resigned bootloader.bin

diff --git a/src/crypto.c b/src/crypto.c

+int
+sign_bl(build_image_context *context,
+	u_int8_t *bootloader,
+	u_int32_t length,
+	u_int32_t image_instance)
+{
+	int e = 0;
+	u_int8_t  *hash_buffer;
+	u_int32_t  hash_size;
+
+	g_soc_config->get_value(token_hash_size,
+			&hash_size, context->bct);

Ah, so there's already a function that can return the size of various objects in
the BCT. That will make option (b) in my review of patch 2 much easier then...

Not sure what you mean exactly.

When I reviewed patch 2/4 I proposed 3 options for a change to ensure that t210_bct_set_value() wasn't tied to chip-specific RSA parameter sizes. Option (b) relied on t210_bct_set_value() calling into an SoC-specific function to retrieve the RSA parameter sizes, which might have meant creating new infra-structure to allow such a call. However, given that g_soc_config->get_value() already exists, and is already used by core code to retrieve the SoC-specific size of some objects, it turns out that implementing option (b) should actually be trivial. Hence, it's the best option.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux