> -----Original Message----- > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > Sent: Wednesday, October 07, 2015 10:01 AM > To: Jimmy Zhang > Cc: Allen Martin; Stephen Warren; linux-tegra@xxxxxxxxxxxxxxx > Subject: Re: [tegrarcm PATCH v2 2/4] Add support for update pubkey and > rsa-pss signatures > > On 10/02/2015 02:56 PM, Jimmy Zhang wrote: > > Create new configuration keywords: > > RsaKeyModulusFile: pubkey modulus > > RsaPssSigBlFile: bootloader rsa pss signature > > RsaPssSigBctFile: bct rsa pss signature > > > > Sample Configuration file update_bl_sig.cfg > > RsaKeyModulusFile = pubkey.mod; > > RsaPssSigBlFile = bl.sig; > > > > where pubkey.mod and bl.sig are files that contain the public key > > modulus and bootloader's rsa-pss signature respectively. > > > > public key modulus and signature are created through utilities outside > > cbootimage. > > > > Command line example: > > $ cbootimage -s tegra210 -u update_bl_sig.cfg image.bin > > image.bin-bl-signed > > > > Above three new keywords added in this CL are only implemented support > > for T210. > > > diff --git a/src/set.c b/src/set.c > > > +set_rsa_param(build_image_context *context, parse_token token, > > + char *filename) > > > + file_type rsa_filetype = file_type_bin; > > + > > + /* Read the image into memory. */ > > + result = read_from_image(filename, > > + 0, > > + ARSE_RSA_PARAM_MAX_BYTES, > > + &rsa_storage, > > + &actual_size, > > + rsa_filetype); > > Why do we need a variable "ras_filetype"? Why not just pass file_type_bin > directly as the function parameter? Agree. Will clean it up. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
