On Mon, 20 Jul 2015 10:04:59 +0200 Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Wed, Jul 01, 2015 at 10:21:52AM +0200, Boris Brezillon wrote: > [...] > > diff --git a/include/linux/pwm.h b/include/linux/pwm.h > [...] > > +struct pwm_state { > > + unsigned int period; /* in nanoseconds */ > > + unsigned int duty_cycle; /* in nanoseconds */ > > + enum pwm_polarity polarity; > > +}; > > No need for the extra padding here. What do you mean by "extra padding" ? I just reused the indentation used in the pwm_device struct. Would you prefer something like that ? struct pwm_state { unsigned int period; /* in nanoseconds */ unsigned int duty_cycle; /* in nanoseconds */ enum pwm_polarity polarity; }; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html